| To: | davem@xxxxxxxxxx |
|---|---|
| Subject: | [PATCH] IPV4: dead lock in error path |
| From: | YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> |
| Date: | Fri, 21 May 2004 17:23:29 +0900 (JST) |
| Cc: | netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx |
| Organization: | USAGI Project |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hello.
We forgot to release ipip_lock in error path.
--yoshfuji
===== net/ipv4/ipip.c 1.40 vs edited =====
--- 1.40/net/ipv4/ipip.c Mon Feb 23 14:45:28 2004
+++ edited/net/ipv4/ipip.c Fri May 21 17:17:28 2004
@@ -479,6 +479,7 @@
read_lock(&ipip_lock);
if ((tunnel = ipip_tunnel_lookup(iph->saddr, iph->daddr)) != NULL) {
if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb)) {
+ read_unlock(&ipip_lock);
kfree_skb(skb);
return 0;
}
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Sluggish performances with FreeBSD, Laurent Goujon |
|---|---|
| Next by Date: | Re: IPSec Oops when deleting an ip address, Herbert Xu |
| Previous by Thread: | Sluggish performances with FreeBSD, Laurent Goujon |
| Next by Thread: | Re: [PATCH] IPV4: dead lock in error path, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |