| To: | hadi@xxxxxxxxxx |
|---|---|
| Subject: | Re: tun device - bug or feature? WAS(Re: IMQ / new Dummy device post. |
| From: | Max Krasnyansky <maxk@xxxxxxxxxxxx> |
| Date: | Mon, 26 Apr 2004 12:31:38 -0700 |
| Cc: | netdev@xxxxxxxxxxx, syrius.ml@xxxxxxxxxx, Jeff Garzik <jgarzik@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx> |
| In-reply-to: | <1082816083.1054.32.camel@xxxxxxxxxxxxxxxx> |
| References: | <wazza.87ad18jbdl.fsf@xxxxxxxxxx> <1082427350.1034.70.camel@xxxxxxxxxxxxxxxx> <wazza.87fzayw1fy.fsf@xxxxxxxxxx> <wazza.87fzaxmr6x.fsf@xxxxxxxxxx> <wazza.87hdvddqxq.fsf@xxxxxxxxxx> <1082639764.1059.81.camel@xxxxxxxxxxxxxxxx> <87oepjx65r.87n053x65r@xxxxxxxxxxxxxxxxxxxxx> <1082719745.1057.27.camel@xxxxxxxxxxxxxxxx> <1082816083.1054.32.camel@xxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 2004-04-24 at 07:14, jamal wrote:
> Maxim,
>
> When TUN_TUN_DEV is used, before the packet is injected into
> the netif_rx() only skb->mac.raw = skb->data is set; the other headers
> are not adjusted. Typically netdevs would do a
> skb_pull(skb,dev->hard_header_len) to make the adjustment.
> I have a feeling this is design intent thats why i didnt send you a
> patch.
Well TUN does not have any hw headers so there is nothing to pull :).
Basically it does what ever PPP driver does. Which is
skb_pull(skb, 2); /* chop off protocol */
skb->dev = ppp->dev;
skb->protocol = htons(npindex_to_ethertype[npi]);
skb->mac.raw = skb->data;
netif_rx(skb);
Max
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Regarding NAPI performance, prashant s |
|---|---|
| Next by Date: | Re: [PATCH] tcp_vegas_cong_avoid doc, David S. Miller |
| Previous by Thread: | Re: tun device - bug or feature? WAS(Re: IMQ / new Dummy device post., David S. Miller |
| Next by Thread: | Re: tun device - bug or feature? WAS(Re: IMQ / new Dummy device post., jamal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |