[Jeff Garzik added to the loop]
[If nobody disagrees, I'll remove l-k from the Cc: during the next round]
Andy Lutomirski <luto@xxxxxxxxxxxxx> :
> This adds ethtool support to r8169.
Cool.
> Some notes: I stole the RxUnderrun interrupt status bit because (1) I
> don't know what a recieve underrun is, (2) the specs say that bit is
> actually "link status changed" and (3) simple tests seem to confirm that.
Ok, this bit is named 'LinkChg' in drivers/net/8139cp.c as well.
> Speed selection doesn't actually set a forced mode but just sets
> autonegotiation to advertise only one speed. (This way there is no ugly
> special case for 1000Mbps.)
>
> The link status is no longer checked on startup because it is slow and, with
> ethtool support, unnecessary.
Just to clarify, it is still done in rtl8169_open() instead of
rtl8169_init_one().
Even if it is a change of behavior in a supposedly stable serie, I guess it is
ok
as it moves the driver in the direction of the 8139cp driver.
> As an added benefit, my 8001S often fails to negotiate 1000Mbps when the
> driver loads but will successfully negotiate it after a while. Running
> 'ethtool -s ethx autoneg on' fixes it, but that's absurd. This patch
> will, ten seconds after the driver starts, check if 1000Mbps is advertised
> but not selected, and, if so, force a renegotiation.
So you can not reliably remove the phy timer and simply use the LinkChg status
change, right ?
Is everybody fine if I cook up a serie of patches for -netdev/-mm inclusion
which includes:
- your link related changes
- start of a 8139cp.c genetic mutation on top of those
- reworked Jon D Mason's NAPI changes
ETA: this week end, start of incoming week.
--
Ueimor
|