netdev
[Top] [All Lists]

Re: [PATCH] r8169 NAPI addition

To: Jon D Mason <jonmason@xxxxxxxxxx>
Subject: Re: [PATCH] r8169 NAPI addition
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Tue, 20 Apr 2004 18:25:01 +0200
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <OF22F0D968.EDCFE67B-ON87256E7C.0053AE89-86256E7C.005628A4@xxxxxxxxxx>; from jonmason@xxxxxxxxxx on Tue, Apr 20, 2004 at 09:45:07AM -0600
References: <20040419224911.A17362@xxxxxxxxxxxxxxxxxxxxxxxxxx> <OF22F0D968.EDCFE67B-ON87256E7C.0053AE89-86256E7C.005628A4@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
Jon D Mason <jonmason@xxxxxxxxxx> :
[...]
> I assume you are referring to the driver being used in weakly ordered 
> memory model machines.  To address this I added a rmb() after the update 
> to the interrupt mask.

Nonono, it is a PCI thing. Writes to (pci-)MMIO registers are posted and
typically require a read in the MMIO range (or "some" time) to be committed
to the final device. (pci-)IO accesses do not exhibit this property.

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>