netdev
[Top] [All Lists]

[PATCH] remove redundant check in de2104x ->get_regs()

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH] remove redundant check in de2104x ->get_regs()
From: Chris Wright <chrisw@xxxxxxxx>
Date: Fri, 16 Apr 2004 15:37:54 -0700
Cc: netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
Hi Jeff,

Trivial patchlet...ethtool core already caps regs.len at a max of
->get_regs_len():

        reglen = ops->get_regs_len(dev);
        if (regs.len > reglen)
                regs.len = reglen;

So doing the same in the in de2104x driver ->get_regs() is redundant.
Patch below simply removes it to clarify the guarantee of the API.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

===== drivers/net/tulip/de2104x.c 1.29 vs edited =====
--- 1.29/drivers/net/tulip/de2104x.c    Wed Mar 17 11:32:53 2004
+++ edited/drivers/net/tulip/de2104x.c  Fri Apr 16 15:31:55 2004
@@ -1676,8 +1676,6 @@
 {
        struct de_private *de = dev->priv;
 
-       if (regs->len > DE_REGS_SIZE)
-               regs->len = DE_REGS_SIZE;
        regs->version = (DE_REGS_VER << 2) | de->de21040;
 
        spin_lock_irq(&de->lock);

<Prev in Thread] Current Thread [Next in Thread>