netdev
[Top] [All Lists]

Re: [PATCH] fix tuntap oversight

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] fix tuntap oversight
From: Jeremy Martin <martinjd@xxxxxxxxxxx>
Date: Mon, 12 Apr 2004 09:29:16 -0700
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20040412001551.05476658.davem@xxxxxxxxxx>
References: <20040412065947.GC18810@xxxxxxxxxxxxx> <20040412001551.05476658.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Mon, Apr 12, 2004 at 12:15:51AM -0700, David S. Miller wrote:
> 
> This netif_running() check is not necessary, and in fact
> wrong.
> 
> In fact, if ethernet drivers erroneously do this, this causes
> them to fail to support the ALB bonding driver modes which
> require on-the-fly MAC address changes while the interface is
> up.
> 

I just took a look in drivers/net/
and 
        acenic.c
        atarilance.c
        b44.c
        cs89x0.c
        net_init.c
        typhoon.c

all use that netif_running() check when setting the MAC.  I actually just pulled
the function from net_init.c for the tun change.  Are these broken?
(I'm asking in total ignorance so be gentle :).

-Jeremy

<Prev in Thread] Current Thread [Next in Thread>