[Top] [All Lists]

Re: [PATCH] tulip, kernel 2.4.26-rc2, 2nd try

To: Timothy I Mattox <tmattox@xxxxxxxxxxxx>
Subject: Re: [PATCH] tulip, kernel 2.4.26-rc2, 2nd try
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Fri, 09 Apr 2004 15:33:19 -0400
Cc: tulip-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.43.0404091519200.19041-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <Pine.LNX.4.43.0404091519200.19041-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Timothy I Mattox wrote:
Resubmitting ADMtek Comet MII support patch...

Here is a patch for the tulip driver found in kernel 2.4.26-rc2
This adds MII functionality to the ADMtek Comet flavor of the tulip,
specifically, the ability to detect and report the link status with MII.
This is critical for use with newer channel bonding drivers.

I've tested on several Linksys LNE100TX v4.1 PCI cards, as well as on
an HP Pavilion N5475 laptop with a built-in NIC that is detected as
this same model of chip.  I have over 750 of this model tulip card in
use in various beowulf clusters.

This patch was modeled after Donald Becker's tulip.c:v0.98 1/8/2004, but
the specific bits from his driver have been there for about two years.

Looks OK, but can you test without netif_carrier_xxx commented out?

I would prefer to leave those active.


<Prev in Thread] Current Thread [Next in Thread>