netdev
[Top] [All Lists]

[PATCH] (3/4) usb gadget -- use random_ether_addr

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH] (3/4) usb gadget -- use random_ether_addr
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Fri, 9 Apr 2004 11:45:50 -0700
Cc: netdev@xxxxxxxxxxx, linux-usb-devel@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20040408145403.34382c96.davem@xxxxxxxxxx>
Organization: Open Source Development Lab
References: <20040408110834.2fd1bd25@xxxxxxxxxxxxxxxxxxxxx> <20040408145403.34382c96.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Use new common code in ether_device.h for random_ether_addr.
Same exact code just in one common place.

diff -Nru a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
--- a/drivers/usb/gadget/ether.c        Fri Apr  9 11:39:51 2004
+++ b/drivers/usb/gadget/ether.c        Fri Apr  9 11:39:51 2004
@@ -1804,17 +1804,13 @@
        /* one random address for the gadget device ... both of these could
         * reasonably come from an id prom or a module parameter.
         */
-       get_random_bytes (net->dev_addr, ETH_ALEN);
-       net->dev_addr [0] &= 0xfe;      // clear multicast bit
-       net->dev_addr [0] |= 0x02;      // set local assignment bit (IEEE802)
+       random_ether_addr(net->dev_addr);
 
 #ifdef DEV_CONFIG_CDC
        /* ... another address for the host, on the other end of the
         * link, gets exported through CDC (see CDC spec table 41)
         */
-       get_random_bytes (node_id, sizeof node_id);
-       node_id [0] &= 0xfe;    // clear multicast bit
-       node_id [0] |= 0x02;    // set local assignment bit (IEEE802)
+       random_ether_addr(node_id);
        snprintf (ethaddr, sizeof ethaddr, "%02X%02X%02X%02X%02X%02X",
                node_id [0], node_id [1], node_id [2],
                node_id [3], node_id [4], node_id [5]);

<Prev in Thread] Current Thread [Next in Thread>