Re: [PATCH] NETDEBUG network triggerable messages in IPv6

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20040409193123.63e4cdc7.ak@xxxxxxx> (at Fri, 9 Apr 2004 19:31:23 
+0200), Andi Kleen <ak@xxxxxxx> says:

> > I don't like the style; it is too ugly.
> > E.g. please do not put "if () ..." into the macro argument.
> 
> Ok, here is a new version that defines a new macro LIMIT_NETDEBUG that does 
> the
> rate limit implicitely.
> -                             if (net_ratelimit())
> -                                     printk(KERN_WARNING "overrun 
> destopt\n"); 
> +                             LIMIT_NETDEBUG(
> +                                     printk(KERN_WARNING "overrun 
> destopt\n")); 

Grr...

I'd prefer:

  if (net_ratelimit())
    NETDEBUG_PRINTK("overrun destopt\n"..)
or

  NETDEBUG_PRINTK_LIMIT("overrun destopt\n"..)

(or something like this) much more.

--yoshfuji