netdev
[Top] [All Lists]

Re: r8169, 2.6.2-rc2, Sager 4780 laptop

To: bhartin@xxxxxxxxxxxxxxxx
Subject: Re: r8169, 2.6.2-rc2, Sager 4780 laptop
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Wed, 7 Apr 2004 01:38:41 +0200
Cc: netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0404061758570.17117@xxxxxxxxxxxxxxxxxxxxxx>; from bhartin@xxxxxxxxxxxxxxxx on Tue, Apr 06, 2004 at 06:03:03PM -0500
References: <Pine.LNX.4.58.0401261443190.7894@xxxxxxxxxxxxxxxxxxxxxx> <20040126235559.A3832@xxxxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.58.0404041553010.6853@xxxxxxxxxxxxxxxxxxxxxx> <20040405002028.A8125@xxxxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.58.0404061650310.20664@xxxxxxxxxxxxxxxxxxxxxx> <20040407001815.C7833@xxxxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.58.0404061758570.17117@xxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
bhartin@xxxxxxxxxxxxxxxx <bhartin@xxxxxxxxxxxxxxxx> :
[...]
> I got my laptop back up and found the messages logged:
> 
> kernel: r8169: eth0: Reset RTL8169s PHY
> 
> I didn't see exactly at what point this started happening during the 
> shutdown, but the message repeated about 500 times before the system 
> logger was stopped.

It implies a minimum of 6000 invocations of rtl8169_phy_timer(). 

*doh*

Please apply patch below.



mod_timer() expects an absolute time, not a relative offset.


 drivers/net/r8169.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/r8169.c~r8169-mod_timer drivers/net/r8169.c
--- linux-2.6.5/drivers/net/r8169.c~r8169-mod_timer     2004-04-07 
01:30:14.000000000 +0200
+++ linux-2.6.5-fr/drivers/net/r8169.c  2004-04-07 01:32:53.000000000 +0200
@@ -617,7 +617,7 @@ static void rtl8169_phy_timer(unsigned l
                }
        }
 
-       mod_timer(timer, RTL8169_PHY_TIMEOUT);
+       mod_timer(timer, jiffies + RTL8169_PHY_TIMEOUT);
 }
 
 static inline void rtl8169_delete_timer(struct net_device *dev)

_

<Prev in Thread] Current Thread [Next in Thread>