Re: [PATCH] make lock/release

netdev

Re: [PATCH] make lock/release_sock fast calls

To:	Stephen Hemminger <shemminger@xxxxxxxx>
Subject:	Re: [PATCH] make lock/release_sock fast calls
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Wed, 31 Mar 2004 23:07:17 -0800
Cc:	netdev@xxxxxxxxxxx
In-reply-to:	<20040331112407.66309027@xxxxxxxxxxxxxxxxxxxxx>
References:	<20040331112407.66309027@xxxxxxxxxxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

On Wed, 31 Mar 2004 11:24:07 -0800
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> lock_sock and release_sock are no longer inline, but they are called in
> the critical path of many operations, so it makes sense to use register based
> fastcall.

I think I'll add this change when 2.6.6 opens up.

Someone haggled about CONFIG_REGPARM, but that argument is crap.
We have "FASTCALL()" for a reason, and CONFIG_REGPARM does not
obviate it.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] make lock/release_sock fast calls, Stephen Hemminger Re: [PATCH] make lock/release_sock fast calls, Christoph Hellwig Re: [PATCH] make lock/release_sock fast calls, David S. Miller <=

Previous by Date:	Re: [PATCH] fix IGMPv3 timer initialization when device not "upped", David S. Miller
Next by Date:	Re: [PATCH 2.6] reference count cleanup continued -IPv6, David S. Miller
Previous by Thread:	Re: [PATCH] make lock/release_sock fast calls, Christoph Hellwig
Next by Thread:	[RFC] Use RCU for fib_rules, Stephen Hemminger
Indexes:	[Date] [Thread] [Top] [All Lists]