[PATCH] Uninitialized timer in ip_mc_down

[Olaf Kirch <okir@xxxxxxx>]

Hi,

if you do the following on a downed interface on 2.6, you get two
"uninitialized timer" messages from the kernel, along with a stack trace.

        ip addr add 1.2.3.4 dev eth1
        ip addr del 1.2.3.4 dev eth1

The reason is that inetdev_create calls ip_mc_up if and only if the device
is up. However, inetdev_destroy calls ip_mc_destroy_dev unconditionally,
so that del_timer gets called for the two multicast timers which are
uninitialized.

The attached patch seems to fix this. An alternative patch would
be to add a check to ip_mc_down to see whether the timers are
actually active before deleting them.

Olaf
-- 
Olaf Kirch     |  Stop wasting entropy - start using predictable
okir@xxxxxxx   |  tempfile names today!
---------------+

ipv4-mcast-timer
Description: Text document