| To: | Leonid Grossman <leonid.grossman@xxxxxxxx> |
|---|---|
| Subject: | Re: Submission #4 for S2io 10GbE driver |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Sat, 20 Mar 2004 05:00:54 -0500 |
| Cc: | netdev@xxxxxxxxxxx, "'ravinandan arakali'" <ravinandan.arakali@xxxxxxxx>, raghavendra.koushik@xxxxxxxx |
| In-reply-to: | <405C153A.2020809@xxxxxxxxx> |
| References: | <001001c40e34$d2c3c4b0$0300a8c0@xxxxxxxxxxxx> <405C153A.2020809@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 |
Jeff Garzik wrote: ===== drivers/net/s2io.h 1.1 vs 1.2 ===== --- 1.1/drivers/net/s2io.h Sat Mar 20 04:38:16 2004 +++ 1.2/drivers/net/s2io.h Sat Mar 20 04:47:53 2004 @@ -14,8 +14,8 @@ #define _S2IO_H#define TBD 0-#define BIT(loc) (((u64)0x8000000000000000ULL) >> loc) -#define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz)) +#define BIT(loc) (1ULL << (loc)) +#define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz)) and here is a patch correcting an incorrect cleanup... ===== drivers/net/s2io.h 1.2 vs edited ===== --- 1.2/drivers/net/s2io.h Sat Mar 20 04:47:53 2004 +++ edited/drivers/net/s2io.h Sat Mar 20 04:59:28 2004 @@ -14,7 +14,7 @@ #define _S2IO_H #define TBD 0 -#define BIT(loc) (1ULL << (loc)) +#define BIT(loc) (0x8000000000000000ULL >> (loc)) #define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz)) #ifndef BOOL |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC, PATCH 4/5]: netfilter+ipsec - policy lookup, Patrick McHardy |
|---|---|
| Next by Date: | Re: [BK] XFRM Clean-Up xfrm_lookup(), David S. Miller |
| Previous by Thread: | Re: Submission #4 for S2io 10GbE driver, Christoph Hellwig |
| Next by Thread: | RE: Submission #4 for S2io 10GbE driver, ravinandan arakali |
| Indexes: | [Date] [Thread] [Top] [All Lists] |