Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h

netdev

Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h

To:	Linus Torvalds <torvalds@xxxxxxxx>
Subject:	Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h
From:	Russell King <rmk+lkml@xxxxxxxxxxxxxxxx>
Date:	Tue, 16 Mar 2004 20:17:10 +0000
Cc:	Ian Campbell <icampbell@xxxxxxxxx>, netdev@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to:	<Pine.LNX.4.58.0403161133430.17272@xxxxxxxxxxxxxxx>; from torvalds@xxxxxxxx on Tue, Mar 16, 2004 at 11:34:56AM -0800
Mail-followup-to:	Linus Torvalds <torvalds@xxxxxxxx>, Ian Campbell <icampbell@xxxxxxxxx>, netdev@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
References:	<1079369568.19012.100.camel@icampbell-debian> <20040316001141.C29594@xxxxxxxxxxxxxxxxxxxxxx> <20040316192247.A7886@xxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.58.0403161133430.17272@xxxxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.2.5.1i

On Tue, Mar 16, 2004 at 11:34:56AM -0800, Linus Torvalds wrote:
> On Tue, 16 Mar 2004, Russell King wrote:
> > > 
> > > What are your thoughts on this?
> > 
> > So how do we solve this problem.  Should I just merge this change and
> > ask you to pull it?  I think that's rather impolite though.
> 
> I didn't apply the patch because you said it was untested ;)

Ok, I've now tested the removal of linux/irq.h from netpoll.h and it
built fine for me on ARM.

However, whether there's a reason for it to be there on x86 or not
still remains to be proven.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Do not include linux/irq.h from linux/netpoll.h, Ian Campbell Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Russell King Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Russell King Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Linus Torvalds Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Russell King Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Russell King <= Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Adrian Bunk Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Christoph Hellwig

Previous by Date:	Re: [PATCH] C99 initializers for net/ipv4/ipvs/ip_vs_lblcr.c, David S. Miller
Next by Date:	Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Adrian Bunk
Previous by Thread:	Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Russell King
Next by Thread:	Re: [PATCH] Do not include linux/irq.h from linux/netpoll.h, Adrian Bunk
Indexes:	[Date] [Thread] [Top] [All Lists]