| To: | "David S. Miller" <davem@xxxxxxxxxx>, Maxim Krasnyansky <maxk@xxxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] tun - don't obscure error return from misc_register |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Mon, 15 Mar 2004 10:25:39 -0800 |
| Cc: | vtun@xxxxxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| Organization: | Open Source Development Lab |
| Sender: | netdev-bounce@xxxxxxxxxxx |
When Tun initialization fails it shouldn't obscure the error return,
There are several reasons it could fail, and when diagnosing user problems
the error code might provide more info.
diff -Nru a/drivers/net/tun.c b/drivers/net/tun.c
--- a/drivers/net/tun.c Mon Mar 15 10:13:37 2004
+++ b/drivers/net/tun.c Mon Mar 15 10:13:37 2004
@@ -609,15 +609,15 @@
int __init tun_init(void)
{
+ int ret = 0;
+
printk(KERN_INFO "Universal TUN/TAP device driver %s "
"(C)1999-2002 Maxim Krasnyansky\n", TUN_VER);
- if (misc_register(&tun_miscdev)) {
+ ret = misc_register(&tun_miscdev);
+ if (ret)
printk(KERN_ERR "tun: Can't register misc device %d\n",
TUN_MINOR);
- return -EIO;
- }
-
- return 0;
+ return ret;
}
void tun_cleanup(void)
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] tun -- name fix, Stephen Hemminger |
|---|---|
| Next by Date: | [PATCH] tun, Stephen Hemminger |
| Previous by Thread: | [PATCH] tun -- name fix, Stephen Hemminger |
| Next by Thread: | Re: [PATCH] tun - don't obscure error return from misc_register, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |