| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | [e1000 netdev-2.6 5/6] collision retry count too high |
| From: | "Feldman, Scott" <scott.feldman@xxxxxxxxx> |
| Date: | Sat, 21 Feb 2004 23:34:49 -0800 (PST) |
| Cc: | netdev@xxxxxxxxxxx, "Feldman, Scott" <scott.feldman@xxxxxxxxx> |
| Reply-to: | "Feldman, Scott" <scott.feldman@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
* For half duplex, the IEEE says collision retry count should
be 15 not 16. Would cause really slow transfers on some hubs
(i.e NetGear DS108).
----------
diff -Naurp netdev-2.6/drivers/net/e1000/e1000_hw.h
netdev-2.6/drivers/net/e1000.mod/e1000_hw.h
--- netdev-2.6/drivers/net/e1000/e1000_hw.h 2004-02-20 14:07:57.000000000
-0800
+++ netdev-2.6/drivers/net/e1000.mod/e1000_hw.h 2004-02-20 14:08:39.000000000
-0800
@@ -1540,7 +1540,7 @@ struct e1000_hw {
#define PBA_SIZE 4
/* Collision related configuration parameters */
-#define E1000_COLLISION_THRESHOLD 16
+#define E1000_COLLISION_THRESHOLD 15
#define E1000_CT_SHIFT 4
#define E1000_COLLISION_DISTANCE 64
#define E1000_FDX_COLLISION_DISTANCE E1000_COLLISION_DISTANCE
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [e1000 netdev-2.6 4/6] delay may be too small, Feldman, Scott |
|---|---|
| Next by Date: | [e1000 netdev-2.6 6/6] handle register_netdev failure, Feldman, Scott |
| Previous by Thread: | [e1000 netdev-2.6 4/6] delay may be too small, Feldman, Scott |
| Next by Thread: | [e1000 netdev-2.6 6/6] handle register_netdev failure, Feldman, Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |