netdev
[Top] [All Lists]

Re: [PATCH] IPV6: clean-up ndisc printk's

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] IPV6: clean-up ndisc printk's
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 11 Feb 2004 11:18:23 -0800
Cc: yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040211111616.34c18a2c.davem@xxxxxxxxxx>
References: <20040210.164650.109511390.yoshfuji@xxxxxxxxxxxxxx> <20040211111616.34c18a2c.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 11 Feb 2004 11:16:16 -0800
"David S. Miller" <davem@xxxxxxxxxx> wrote:

> On Tue, 10 Feb 2004 16:46:50 +0900 (JST)
> YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> wrote:
> 
> > D: print KERN_xxx appropriately.
> > D: put net_ratelimit() inside the macro.
> > D: re-arrange levels.

Actually, no, this makes GCC upset.  I have to revert the patch.

Please fix this:

net/ipv6/ndisc.c:1283:40: pasting "(" and "KERN_ERR" does not give a valid 
preprocessing token
net/ipv6/ndisc.c:1442:31: pasting "(" and "KERN_ERR" does not give a valid 
preprocessing token

Thanks.


<Prev in Thread] Current Thread [Next in Thread>