netdev
[Top] [All Lists]

Re: Change proxy_arp to respond only for valid neighbours

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: Change proxy_arp to respond only for valid neighbours
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 9 Feb 2004 14:45:57 -0800
Cc: netdev@xxxxxxxxxxx, kuznet@xxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0402100033050.1251@xxxxxxxxxxxx>
References: <Pine.LNX.4.58.0402082234110.6268@xxxxxxxxxxxx> <20040209121926.6f016ebf.davem@xxxxxxxxxx> <4027FE27.9020102@xxxxxxxxxxxxxxx> <20040209134551.3bd533a2.davem@xxxxxxxxxx> <Pine.LNX.4.58.0402100033050.1251@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 10 Feb 2004 00:42:47 +0200 (EET)
Julian Anastasov <ja@xxxxxx> wrote:

> I'm ready to leave this idea if the changes become too complex.

I think it's not so much your changes as this huge ugly ARP receive
processing function.  It is a mockery of functional programming :-)

I even tried to split this damn thing up today into smaller chunks but
there is so much shared state (like 6 or 7 live variables that all of
the logic ends up referencing) that such efforts proved futile.

It's hard and time consuming to verify any patch to this code for
that reason.

<Prev in Thread] Current Thread [Next in Thread>