| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: [NFS] [PATCH][RFC] use completions instead of sleep_on for rpciod |
| From: | Olaf Kirch <okir@xxxxxxx> |
| Date: | Mon, 9 Feb 2004 11:28:01 +0100 |
| Cc: | netdev@xxxxxxxxxxx, nfs@xxxxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20040207144405.GA19416@xxxxxx> |
| References: | <20040207144405.GA19416@xxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4i |
On Sat, Feb 07, 2004 at 03:44:05PM +0100, Christoph Hellwig wrote: > The rpciod shutdown code gives ugly sleep_on without BKL warnings in > -mm. And it looks indeed somewhat racy. Yes, this code is indeed one of the areas that breaks when you use the sunrpc code without the BKL. Another one was the missing spinlock in xprt_alloc_xid. The code in fs/nfs/unlink.c is probably also racy without BKL. So if you remove the sunrpc BKL be prepared for lots and lots of bug reports :) Olaf -- Olaf Kirch | Stop wasting entropy - start using predictable okir@xxxxxxx | tempfile names today! ---------------+ |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 3/3][bonding][2.6] Add VLAN support in ALB mode, Shmuel Hen |
|---|---|
| Next by Date: | Re: Change proxy_arp to respond only for valid neighbours, Julian Anastasov |
| Previous by Thread: | Re: [PATCH][RFC] use completions instead of sleep_on for rpciod, David S. Miller |
| Next by Thread: | Re: [NFS] [PATCH][RFC] use completions instead of sleep_on forrpciod, trond . myklebust |
| Indexes: | [Date] [Thread] [Top] [All Lists] |