netdev
[Top] [All Lists]

Re: some bluetooth fixes

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: some bluetooth fixes
From: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Date: Sat, 07 Feb 2004 17:57:48 +0100
Cc: bluez-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx
In-reply-to: <20040207125723.391a1fcd.ak@xxxxxxx>
References: <20040206050042.20a2b3b0.ak@xxxxxxx> <1076079512.2806.40.camel@pegasus> <20040207032428.56ffbebc.ak@xxxxxxx> <1076152411.14418.73.camel@pegasus> <20040207125723.391a1fcd.ak@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Hi Andi,

> > I check this. Maybe we have more of them. What do you propose as max
> > size value for kmalloc? 2*PAGE_SIZE or 4*PAGE_SIZE?
> 
> What better fits the intended use case. I don't know how many objects are 
> expected
> here. Smaller is better probably.

I now looked carefully through your patch and changed and added some
parts to better fit into. I also fixed another RFCOMM refcount bug.
Please review it, before I send it to Dave.

> If you want to handle more objects this way you should use seq_file instead.

The general plan is to move over to sysfs.

Regards

Marcel

Attachment: patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>