In article <4024C1D5.5030906@xxxxxxxxxxx> (at Sat, 07 Feb 2004 12:45:41 +0200),
Mika Penttilä <mika.penttila@xxxxxxxxxxx> says:
> >> I think you missed our ndsic_dst_alloc() change.
> >> ndisc_dst_alloc() takes 4 argument:
> >> struct dst_entry *ndisc_dst_alloc(struct net_device *dev,
> >> struct neighbour *neigh,
> >> struct in6_addr *addr,
> >> int (*output)(struct sk_buff *));
> >> If neigh is NULL, we do ndisc_get_neigh(dev, addr) to get one.
> > hmm. where is this ndisc_dst_alloc() change? In the patch it's called
> > with three params, only the output routine is changed :
> > - dst = ndisc_dst_alloc(dev, NULL, ndisc_output);
> > + dst = ndisc_dst_alloc(dev, NULL, ip6_output2);
> I see, it was in a follow-up patch. Ok, I was just looking at the
> original patch, which didn't work. But with this ndisc_dst_alloc()
> change it's ok.
Oh my god!!
Miyazawa-san failed to export our "correct" code in original patch.
I didn't noticed that.
We're sorry about it. Thank you for spotting the bug.
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA