netdev
[Top] [All Lists]

Re: Source Specific Query of MLDv2 [PATCH]

To: dlstevens@xxxxxxxxxx
Subject: Re: Source Specific Query of MLDv2 [PATCH]
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sat, 07 Feb 2004 15:46:03 +0900 (JST)
Cc: davem@xxxxxxxxxx, hibi665@xxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <OF92ABDC1A.4056C324-ON88256E33.002267FA-88256E33.00247258@xxxxxxxxxx>
Organization: USAGI Project
References: <20040207.142519.117436499.yoshfuji@xxxxxxxxxxxxxx> <OF92ABDC1A.4056C324-ON88256E33.002267FA-88256E33.00247258@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article 
<OF92ABDC1A.4056C324-ON88256E33.002267FA-88256E33.00247258@xxxxxxxxxx> (at Fri, 
6 Feb 2004 22:40:42 -0800), David Stevens <dlstevens@xxxxxxxxxx> says:

> Good idea; I'll incorporate all the comments, retest and repost.
> 
> > So... hmm... Let's check dev->flags ^ (IFF_PROMISC|IFF_ALLMULTI) like
> this.
> 
>       I think you mean (dev->flags & (IFF_PROMISC|IFF_ALLMULTI)) here,
> right?

Oops! Sorry, you're right...
And, it'd be good to use unlikely() here.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

<Prev in Thread] Current Thread [Next in Thread>