netdev
[Top] [All Lists]

Re: Submission for S2io 10GbE driver

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: Submission for S2io 10GbE driver
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Mon, 16 Feb 2004 16:16:31 -0800
Cc: Leonid Grossman <leonid.grossman@xxxxxxxx>, netdev@xxxxxxxxxxx, "'Andi Kleen'" <ak@xxxxxxx>, "'Jeff Garzik'" <jgarzik@xxxxxxxxx>, "'Francois Romieu'" <romieu@xxxxxxxxxxxxx>, "'jamal'" <hadi@xxxxxxxxxx>, "'Grant Grundler'" <iod00d@xxxxxx>, "'Anton Blanchard'" <anton@xxxxxxxxx>, "'Jes Sorensen'" <jes@xxxxxxxxxxxxxxxxxx>, raghavendra.koushik@xxxxxxxx, "'ravinandan arakali'" <ravinandan.arakali@xxxxxxxx>
In-reply-to: <20040217001111.A23086@infradead.org>
Organization: Open Source Development Lab
References: <20040205004952.GA27510@cup.hp.com> <000201c3f4d2$2a5ddd90$7410100a@S2IOtech.com> <20040217001111.A23086@infradead.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 17 Feb 2004 00:11:12 +0000
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> A bunch of comments:
> 
>  - if you want to submit the driver for inclusion please submit a patch 
> against a kernel tree,
>    not a tarball.
>  - please try to avoid version ifdefs by provoding the newer APIs on older 
> kernels, e.g.:
> 
> #ifndef IRQ_RETVAL
> #define irqreturn_t                     void
> #define IRQ_RETVAL(foo)
> #endif
> 
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,00)
> #define free_netdev kfree
> #endif

The proper way for that is:

#ifndef HAVE_FREE_NETDEV
#define free_netdev(x)  kfree(x)
#endif


<Prev in Thread] Current Thread [Next in Thread>