netdev
[Top] [All Lists]

Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrout

To: Mika Penttilä <mika.penttila@xxxxxxxxxxx>
Subject: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook
From: James Morris <jmorris@xxxxxxxxxx>
Date: Sun, 15 Feb 2004 09:03:20 -0500 (EST)
Cc: "David S. Miller" <davem@xxxxxxxxxx>, Harald Welte <laforge@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxxx>
In-reply-to: <402F76C2.6030300@kolumbus.fi>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 15 Feb 2004, Mika Penttilä wrote:

> skb_checksum_help() updates skb->ip_summed to CHECKSUM_NONE in the 
> original skb, and this should be seen by the driver. With your change 
> the checksum is calculated twice, once for the looping back packet, and 
> once for the outgoing.

[Looks like my posts are not making it to netdev]

It updates ip_summed in the cloned packet header, but not in the original 
packet, which gets sent to the driver with an already completed checksum.

See the original post.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>




<Prev in Thread] Current Thread [Next in Thread>