netdev
[Top] [All Lists]

Re: 2.6: QoS scheduling not working with IP-over-IP

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: 2.6: QoS scheduling not working with IP-over-IP
From: jamal <hadi@xxxxxxxxxx>
Date: 11 Feb 2004 23:59:58 -0500
Cc: Dawid Kuroczko <qnex@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, shemminger@xxxxxxxx
In-reply-to: <1076561489.1032.65.camel@jzny.localdomain>
Organization: jamalopolis
References: <Pine.LNX.4.44.0402101324350.810-100000@atlantis.knm.org.pl> <20040211200549.736fa8b3.davem@redhat.com> <1076561489.1032.65.camel@jzny.localdomain>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
What the heck, heres a patch (maybe it ll teach that poster to post to
netdev instead of lk ;->). Not tested not even compiled but looks fine.
ipip was always broken; the pfifo off by one fix in 2.6 seems to have
exposed the bug.

-----
--- 262/net/ipv4/ipip.c 2004-01-09 02:00:13.000000000 -0500
+++ 262-mod/net/ipv4/ipip.c     2004-02-11 23:35:18.000000000 -0500
@@ -247,6 +247,7 @@
        SET_MODULE_OWNER(dev);
        dev->init = ipip_tunnel_init;
        dev->destructor = free_netdev;
+       dev->tx_queue_len = 100;
        nt->parms = *parms;
 
        if (register_netdevice(dev) < 0) {

-------

cheers,
jamal

On Wed, 2004-02-11 at 23:51, jamal wrote:
> Actually this may be a result of the recent tweak to
> the scheduler code that seems to be in 2.6.2. The fix seems
> to fix the off by one in pfifo.
> 
> cheers,
> jamal
> 
> On Wed, 2004-02-11 at 23:05, David S. Miller wrote:
> > [ moving from linux-kernel to correct mailing list... ]
> > 
> > Czesc Dawid,
> > 
> > On Tue, 10 Feb 2004 13:36:32 +0100 (CET)
> > Dawid Kuroczko <qnex@xxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > > There seems to be a bug in QoS scheduling code related to IP-over-IP
> > > tunnels (ipip.ko).  My setup is a bit unusual -- my default route
> > > goes through tunl1, so I want it shaped.  It worked fine with 2.4,
> > > but it doesn't with 2.6 (2.6.1 and 2.6.2, I made a transition quite
> > > recently).
> > 
> > Can you assign QoS schedulers and classifiers successfully to eth0
> > or some other non ipip device?
> > 
> > Does it work with 'tunl0' instead of 'tunl1'?
> > 
> > Stephen, I bet this problem got introduced when we moved ipip.c over
> > to dynamic netdevice allocation, can you take a look?
> > 
> > 
> 
> 
> 


<Prev in Thread] Current Thread [Next in Thread>