netdev
[Top] [All Lists]

Re: [PATCH] more improvement to dev_alloc_name -- strnchr

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] more improvement to dev_alloc_name -- strnchr
From: Andi Kleen <ak@xxxxxxx>
Date: Mon, 19 Jan 2004 21:06:05 +0100
Cc: davem@xxxxxxxxxx, ap@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040119113204.5913a8d6.shemminger@xxxxxxxx>
References: <1074302619.40088e9bd44a6@xxxxxxxxxxxxxxx> <20040119113204.5913a8d6.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 19 Jan 2004 11:32:04 -0800
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> +#ifndef __HAVE_ARCH_STRNCHR

Please drop the ifdef. Don't want to encourage anybody to write
strrchr() in assembly.

-Andi


<Prev in Thread] Current Thread [Next in Thread>