Re: [PATCH 1/5] tun check error on memcpy_fromiovec

[Chris Wright <chrisw@xxxxxxxx>]

* maximilian attems (janitor@xxxxxxxxxxxxxx) wrote:
> hey chris,
> 
> after applying your 4 patches on top of linux-2.6.0 
> + experimental net, 
> found 2 last unchecked memcpy_fromiovec in tun.c
> patch bellow fixes the second call, 
> the first is beyond me, please complete this patch :)
> compile tested

I specifically left those alone.  They have a semi-bogus verify_area()
call that is trying to insure the memcpy_fromiovec won't EFAULT.  I'd
prefer to remove them and simply do memcpy checking.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net