netdev
[Top] [All Lists]

Re: [PATCH]snmp6 64-bit counter support in proc.c

To: Shirley Ma <mashirle@xxxxxxxxxx>
Subject: Re: [PATCH]snmp6 64-bit counter support in proc.c
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 15 Jan 2004 00:57:29 -0800
Cc: kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, xma@xxxxxxxxxx
In-reply-to: <200401141450.43806.mashirle@xxxxxxxxxx>
References: <200312021240.PAA01536@xxxxxxxxxxxxxxx> <200312051214.48076.mashirle@xxxxxxxxxx> <20031205123133.3743fe39.davem@xxxxxxxxxx> <200401141450.43806.mashirle@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 14 Jan 2004 14:52:51 -0800
Shirley Ma <mashirle@xxxxxxxxxx> wrote:

> > "sizeof(unsigned long)" evaluates to 8 on 64-bit systems,
> > yet you assume it always evaluated to 4 as on 32-bit systems.
> >
> > Maybe it would be wiser to explicitly use 'u32' and 'u64' for
> > the types of the snmp counters?
> >
> > This has always been a sore area.
> 
> This is the new patch against 2.6.1 kernel.

I am personally fine with this patch, but I do believe some folks might find
it controversial (for whatever reason) to move all of these stats over to 
64-bits.

So I'm going to let this sit for another day or two so people can voice any
objections they may have.

<Prev in Thread] Current Thread [Next in Thread>