netdev
[Top] [All Lists]

[PATCH 4/5] xfrm_state_construct doesn't set tunnel state

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH 4/5] xfrm_state_construct doesn't set tunnel state
From: Krishna Kumar <krkumar@xxxxxxxxxx>
Date: Tue, 13 Jan 2004 13:24:23 -0800 (PST)
Cc: netdev@xxxxxxxxxxx, KK <krkumar@xxxxxxxxxx>
In-reply-to: <Pine.LNX.4.44.0401131319510.25742-100000@linux-udp14999547uds>
Sender: netdev-bounce@xxxxxxxxxxx
xfrm_state_construct doesn't set x->km.state to XFRM_STATE_DEAD. This can lead
to the BUG_TRAP in __xfrm_state_destroy when xfrm_state_put() finds this is
the last reference. This was reported as one of the symptoms of [Bug 1754]
some time back.

thanks,

- KK

diff -ruN linux-2.6.0-rc2-bk6.org/net/xfrm/xfrm_user.c 
linux-2.6.0-rc2-bk6/net/xfrm/xfrm_user.c
--- linux-2.6.0-rc2-bk6.org/net/xfrm/xfrm_user.c        2004-01-09 
12:57:42.000000000 -0800
+++ linux-2.6.0-rc2-bk6/net/xfrm/xfrm_user.c    2004-01-09 12:59:00.000000000 
-0800
@@ -241,6 +241,7 @@
        return x;

 error:
+       x->km.state = XFRM_STATE_DEAD;
        xfrm_state_put(x);
 error_no_put:
        *errp = err;


<Prev in Thread] Current Thread [Next in Thread>