netdev
[Top] [All Lists]

RE: Submission for S2io 10GbE driver

To: "'Jeff Garzik'" <jgarzik@xxxxxxxxx>
Subject: RE: Submission for S2io 10GbE driver
From: "Leonid Grossman" <leonid.grossman@xxxxxxxx>
Date: Mon, 26 Jan 2004 22:19:47 -0800
Cc: "'Stephen Hemminger'" <shemminger@xxxxxxxx>, "'Andi Kleen'" <ak@xxxxxxx>, <netdev@xxxxxxxxxxx>, <raghavendra.koushik@xxxxxxxx>
Importance: Normal
In-reply-to: <40160060.4010709@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx

> 
> The ethtool diag stuff is more of a quick sanity test than anything 
> exhaustive.
> 
> I definitely want to discourage tons of test code in drivers, as its 
> code that users will almost-never run, it bloats the driver, 
> and can be 
> done with a special diag-only driver or diag program (or a 
> combination 
> of both).
> 
> A lot of the 10/100 drivers originated from Donald Becker, 
> who typically 
> creates a userland (i.e. separate) diag program for each 
> driver he writes.


I see the point; we'll go ahead and get rid of the loopback.
We actually have pretty extensive standalone diag tool that is based on
diag driver.

Thanks, Leonid


> 
>       Jeff
> 
> 
> 


<Prev in Thread] Current Thread [Next in Thread>