| To: | Ingo Molnar <mingo@xxxxxxx> |
|---|---|
| Subject: | Re: [patch] clean up tcp_sk(), 2.6.0 |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Tue, 30 Dec 2003 14:46:08 -0800 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20031230163230.GA12553@xxxxxxx> |
| References: | <20031230163230.GA12553@xxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 30 Dec 2003 17:32:30 +0100 Ingo Molnar <mingo@xxxxxxx> wrote: > i recently wasted a few hours on a bug where i used "tcp_sk(sock)" > instead of "tcp_sk(sock->sk)" - the former, while being blatantly > incorrect, compiles just fine on 2.6.0. The patch below is equivalent to > the define but is also type-safe. Compiles cleanly & boots fine on > 2.6.0. Applied, and I'll happily accept patches for udp_sk() and all the other ones too :) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [patch] clean up tcp_sk(), 2.6.0, Ingo Molnar |
|---|---|
| Next by Date: | Re: [PATCH] [NET] missing sysctl strategy in net/{core,ipv6,appletalk}, David S. Miller |
| Previous by Thread: | Re: [patch] clean up tcp_sk(), 2.6.0, YOSHIFUJI Hideaki / 吉藤英明 |
| Next by Thread: | Re: [patch] clean up tcp_sk(), 2.6.0, Ingo Molnar |
| Indexes: | [Date] [Thread] [Top] [All Lists] |