> version 0.20 of forcedeth (GPLed nvnet replacement for nForce
> on-board nics) for Linux 2.4 and 2.6 is available at
> http://www.hailfinger.org/carldani/linux/patch> es/forcedeth/
Carl-Daniel, I'm bored:
* Consider prefixing function names unique prefix so driver is
not anonymous in backtraces.
* remove_nic: use free_netdev rather than kfree.
* remove_nic: should check if(dev) before dereferencing?
* remove_nic: check np->rx_ring before pci_free_consistent?
* probe_nic: call to get_nvpriv(dev) before checking if(!dev).
* Need minimal ethtool support: GSET/SSET/GDRVINFO/GLINK/
NWAY_RST. ethtool_ops support would be best, but compat w/
2.4 is problematic.
* Use mii.c to get some ethtool support, mii_ioctl support,
and maybe a replacement for update_linkspeed.
* Comment above set_multicast says change_mtu.
* NAPI support would be nice instead of the do_nic_poll timer.
* Consider using NETIF_MSG_XXX levels to test against a
np->msg_enable for better control over message output.
* Replace MODULE_PARM with module_param only for 2.6.
Cheers,
-scott
|