netdev
[Top] [All Lists]

Re: [EXPERIMENTAL PATCH] 2.4 tulip jumbo frames

To: Rask Ingemann Lambertsen <rask@xxxxxxxxxx>
Subject: Re: [EXPERIMENTAL PATCH] 2.4 tulip jumbo frames
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 09 Dec 2003 11:45:42 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031209160632.D1345@xxxxxxxxxx>
References: <20031209160632.D1345@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Two questions and a comment...

Would you split this into two patches? The first simply adds, and uses, tp->rx_buf_sz. The second adds PKT_BUF_SZ_MAX and mtu-related changes.

Have you looked at Donald Becker's changes to tulip.c? He went through most of his drivers and made the changes necessary to support larger MTUs. IIRC his tulip.c changes (which should be easily translate-able to 2.6.x tulip) were a bit more minimal than your patch, but still served the purpose.

For the comment: I am curious why a VLAN_xxx constant is included in the calculation of max MTU, in the ->change_mtu hook? IMO ->change_mtu simply needs to bind the MTU to the min and max h/w limits. If VLAN_ETH_HLEN ever figures into the calculations, those calculations should occur elsewhere, not in ->change_mtu.

Thanks!

        Jeff





<Prev in Thread] Current Thread [Next in Thread>