netdev
[Top] [All Lists]

Re: [2.6 PATCH] ipchains masquerade must select maddr correctly

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [2.6 PATCH] ipchains masquerade must select maddr correctly
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 2 Dec 2003 16:22:08 -0800
Cc: netdev@xxxxxxxxxxx, laforge@xxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0312030150080.1237-200000@xxxxxxxxxxxx>
References: <Pine.LNX.4.44.0312030150080.1237-200000@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 3 Dec 2003 01:55:28 +0200 (EET)
Julian Anastasov <ja@xxxxxx> wrote:

>       The attached patch fixes ipchains masquerade to use
> correctly the routing. This bug-to-bug compatibility with 2.2
> is not valid from long time. Also, a missing unlock is added.

Slow down.

I don't think it's always desirable to specify a specific TOS when
we're working with an input packet.  In fact, what you're doing all
over the tree is going to cause the routing cache size to explode in
some very real usage.

<Prev in Thread] Current Thread [Next in Thread>