| To: | rmk+lkml@xxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy |
| From: | YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> |
| Date: | Fri, 28 Nov 2003 04:54:13 +0900 (JST) |
| Cc: | felipe_alfaro@xxxxxxxxxxxxx, davem@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx |
| In-reply-to: | <20031127194602.A25015@xxxxxxxxxxxxxxxxxxxxxx> |
| Organization: | USAGI Project |
| References: | <1069934643.2393.0.camel@xxxxxxxxxxxxxxxxxxxxxxxx> <20031127.210953.116254624.yoshfuji@xxxxxxxxxxxxxx> <20031127194602.A25015@xxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
In article <20031127194602.A25015@xxxxxxxxxxxxxxxxxxxxxx> (at Thu, 27 Nov 2003 19:46:02 +0000), Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> says: > > > > I agree, using sizeof() is the less error prone way of > > > > doing things like this. > > > > > > > > Felipe could you please rewrite your patch like this? > > > > > > Done! > > > > Thanks. Ok to me. > > I'm slightly cautious here, although I haven't read the patch yet. > Did anyone consider whether any of these structures were copied to > user space, and whether, as a result of this change, we're now > copying uninitialised data to users? I believe that it, to change from strcpy() to strlcpy(), just eliminates possibility of buffer-overrun. --yoshfuji |
| Previous by Date: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy, Russell King |
|---|---|
| Next by Date: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy, Russell King |
| Previous by Thread: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy, Russell King |
| Next by Thread: | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy, Russell King |
| Indexes: | [Date] [Thread] [Top] [All Lists] |