On Tue, Nov 25, 2003 at 10:20:59PM -0800, David S. Miller wrote:
>
> Thanks for catching this, I'll review and apply your patch soon.
Hmm, it looks like my patch has a slight race in it. It is possible
for a device to be added to a dst, go down and unregister, and then
the dst is added to a bundle.
This isn't really a problem for net devices without destructors though
since the UNREGISTER event is rebroadcast at regular intervals.
However, it also affects xfrm_flush_bundle() and xfrm states don't
enjoy the benefit of repeated flushes.
Here is an updated patch that checks whether a dst is still valid
before adding it to a bundle.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
p
Description: Text document
|