netdev
[Top] [All Lists]

Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy

To: "YOSHIFUJI Hideaki / _$B5HF#1QL@" <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 27 Nov 2003 02:59:21 -0800
Cc: felipe_alfaro@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20031127.173320.19253188.yoshfuji@xxxxxxxxxxxxxx>
References: <1069920883.2476.1.camel@xxxxxxxxxxxxxxxxxxxxxxxx> <20031127.173320.19253188.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 27 Nov 2003 17:33:20 +0900 (JST)
YOSHIFUJI Hideaki / _$B5HF#1QL@ <yoshfuji@xxxxxxxxxxxxxx> wrote:

> -     strcpy(t->parms.name, dev->name);
> +     strlcpy(t->parms.name, dev->name, IFNAMSIZ);
>                                           sizeof(t->parms.name)
> 
> or something like that.

I agree, using sizeof() is the less error prone way of
doing things like this.

Felipe could you please rewrite your patch like this?

Thank you.



<Prev in Thread] Current Thread [Next in Thread>