netdev
[Top] [All Lists]

Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy

To: felipe_alfaro@xxxxxxxxxxxxx
Subject: Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Thu, 27 Nov 2003 17:33:20 +0900 (JST)
Cc: davem@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <1069920883.2476.1.camel@xxxxxxxxxxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <1069920883.2476.1.camel@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <1069920883.2476.1.camel@xxxxxxxxxxxxxxxxxxxxxxxx> (at Thu, 27 Nov 
2003 09:14:44 +0100), Felipe Alfaro Solana <felipe_alfaro@xxxxxxxxxxxxx> says:

> Attached is a patch against 2.6.0-test11 to convert all strcpy() calls
> to their corresponding strlcpy() for IPv6. Compiled and tested.

I don't like this coding style.

diff -uNr linux-2.6.0-test11.orig/net/ipv6/ip6_tunnel.c 
linux-2.6.0-test11/net/ipv6/ip6_tunnel.c
--- linux-2.6.0-test11.orig/net/ipv6/ip6_tunnel.c       2003-11-26 
21:42:56.000000000 +0100
+++ linux-2.6.0-test11/net/ipv6/ip6_tunnel.c    2003-11-27 00:27:09.000000000 
+0100
-       strcpy(t->parms.name, dev->name);
+       strlcpy(t->parms.name, dev->name, IFNAMSIZ);
                                          sizeof(t->parms.name)

or something like that.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>