netdev
[Top] [All Lists]

Re: [PATCH] e100: Enable receiving bogus packets, and transmitting bad/

To: netdev@xxxxxxxxxxx
Subject: Re: [PATCH] e100: Enable receiving bogus packets, and transmitting bad/custom CRC
From: Rask Ingemann Lambertsen <rask@xxxxxxxxxx>
Date: Tue, 25 Nov 2003 15:56:12 +0100
In-reply-to: <3FC298C9.8080302@xxxxxxxxxxxxxxx>; from greearb@xxxxxxxxxxxxxxx on Mon, Nov 24, 2003 at 03:48:25PM -0800
References: <3FC2931B.3070903@xxxxxxxxxxxxxxx> <20031124152933.1420f6cf.davem@xxxxxxxxxx> <3FC298C9.8080302@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
On Mon, Nov 24, 2003 at 03:48:25PM -0800, Ben Greear wrote:
> 
> So, RX-ALL can be one flag, another for RX-FCS, and the TX-CUSTOM-FCS
> can be a separate patch altogether?

Yes. For example, the i82586 can support RX-ALL but not RX-FCS, and
TX-CUSTOM-FCS would be more work than with i82596 and i82557/8/9. Since the
i82586 has a global (as opposed to per TX cmd) TX-CUSTOM-FCS flag, it would
be necessary to send a configure command whenever this flag changes from one
TX skb to another. So yes, please separate these features.

-- 
Regards,
Rask Ingemann Lambertsen

<Prev in Thread] Current Thread [Next in Thread>