netdev
[Top] [All Lists]

Re: [PATCH]: Adjust qlen when grafting in multiple qdiscs

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH]: Adjust qlen when grafting in multiple qdiscs
From: jamal <hadi@xxxxxxxxxx>
Date: 17 Nov 2003 14:25:01 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, Werner Almesberger <werner@xxxxxxxxxxxxxxx>
In-reply-to: <3FB9103C.9080504@xxxxxxxxx>
Organization: jamalopolis
References: <3FB3996A.6080008@xxxxxxxxx> <1069076786.1075.19.camel@xxxxxxxxxxxxxxxx> <3FB8DDE0.1070105@xxxxxxxxx> <1069081153.1022.20.camel@xxxxxxxxxxxxxxxx> <3FB8F3BF.6050509@xxxxxxxxx> <1069090210.1022.64.camel@xxxxxxxxxxxxxxxx> <3FB9103C.9080504@xxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2003-11-17 at 13:15, Patrick McHardy wrote:

> >My opinion is that since these interfaces (ex qdisc) exist they
> >exist to be (ab)used. 
> >Dsmark happens to work well with the single queue - maybe thats what
> >needs to be documented as opposed to saying it deviates from a purist
> >angle.
> >  
> >
> As I said I've never used dsmark, I changed it while fixing TBF (where
> it is a problem, TBF was changed not long ago to support attaching inner
> qdiscs), so anything is fine with me. I just became a purist defending
> correctness of the patch ;)

Now that we have invoked Werner - lets wait for his response then ;->
Sorry, didnt meant to drag this into 5-6 emails thread.
I closely looked at your other changes on that patch and they looked
fine.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>