netdev
[Top] [All Lists]

Re: [PATCH] Updated 8139too with NAPI

To: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Updated 8139too with NAPI
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 12 Nov 2003 11:01:31 -0500
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <87d6bx4ms1.fsf@xxxxxxxxxxxxxxxxxxx>
References: <3F9070B6.9090306@xxxxxxxxx> <873cdqbt6z.fsf@xxxxxxxxxxxxxxxxxxx> <20031020131106.6862e951.shemminger@xxxxxxxx> <877k2ysohc.fsf@xxxxxxxxxxxxxxxxxxx> <20031028114707.1d234da6.shemminger@xxxxxxxx> <3FA01629.2080202@xxxxxxxxx> <873cdaabue.fsf@xxxxxxxxxxxxxxxxxxx> <20031030104943.20b61af0.shemminger@xxxxxxxx> <87ekwu9tn4.fsf@xxxxxxxxxxxxxxxxxxx> <20031111143143.794909e8.shemminger@xxxxxxxx> <87d6bx4ms1.fsf@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
OGAWA Hirofumi wrote:
    netif_rx_complete(dev);
    -- interrupted --
        in rtl8139_interrupt(),
                if (netif_rx_schedule_prep(dev)) {
                        RTL_W16_F (IntrMask, rtl8139_norx_intr_mask);
                        __netif_rx_schedule (dev);
                }
    -- resume --
    /* enable interrupt, but rx-poll is already scheduling */
    RTL_W16_F(IntrMask, rtl8139_intr_mask);


good point...


<Prev in Thread] Current Thread [Next in Thread>