netdev
[Top] [All Lists]

net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags

To: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
Subject: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags
From: "Ihar 'Philips' Filipau" <filia@xxxxxxxxxxxx>
Date: Mon, 10 Nov 2003 12:10:46 +0100
Cc: netdev@xxxxxxxxxxx
Organization: Home Sweet Home
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20030927
Hi!

[ I'm trying to cc: netdev - but they are not that welcome - and require subscription. I'm way too lazy (and my mail box is not that fast) to subscribe to send simple typo - if this is a case at all. ]

[ kernel v2.6.0-test7 as found on lxr.linux.no, 2.4.{18,22} has the same - but line numbers are different. ]

On line 1057 we have: "msg->msg_flags|=MSG_TRUNC;" to indicate that message was truncated.

But on line 1073, where we make return status to user, we check against user suplied flags, but NOT msg->msg_flags.

   It looks like obvious typo.

--
Ihar 'Philips' Filipau  / with best regards from Saarbruecken.
--                                                           _ _ _
 "... and for $64000 question, could you get yourself       |_|*|_|
   vaguely familiar with the notion of on-topic posting?"   |_|_|*|
                                -- Al Viro @ LKML           |*|*|*|


<Prev in Thread] Current Thread [Next in Thread>