netdev
[Top] [All Lists]

Re: problem in driver network code

To: francois donzet <fdonzet@xxxxxxxx>
Subject: Re: problem in driver network code
From: Rask Ingemann Lambertsen <rask@xxxxxxxxxx>
Date: Fri, 7 Nov 2003 18:15:12 +0100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031107083844.74787.qmail@xxxxxxxxxxxxxxxxxxxxxxxxxxx>; from fdonzet@xxxxxxxx on Fri, Nov 07, 2003 at 09:38:44AM +0100
References: <20031107083844.74787.qmail@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
On Fri, Nov 07, 2003 at 09:38:44AM +0100, francois donzet wrote:
> 
> It seems to me that there is a problem ;). If i store
> in skb->csum a sum of all words of the packet data, it
>  will be unusable by tcp (the skb->csum doesn't
> contain the checksum of tcpheader plus data only, as
> the ipheader is part of the packet when the sum is
> computed)

That can be accounted for by the TCP code because the IP header is known to
the TCP code. IIRC, the pseudoheader is similiar to a real IP header, so it
may take just a few lines of code to make up for the difference, but I
haven't checked that.

What do you do with an IEEE 802.1q (VLAN) or 802.2 (LLC) packet? The VLAN
code in vlan_skb_recv() does not adjust skb->csum or skb->ip_summed. Neither
does the 802.2 code.

-- 
Regards,
Rask Ingemann Lambertsen

<Prev in Thread] Current Thread [Next in Thread>