netdev
[Top] [All Lists]

Fw: why is mode of /proc/sys/net/ipv6/icmp directory only 0500?

To: davem@xxxxxxxxxx
Subject: Fw: why is mode of /proc/sys/net/ipv6/icmp directory only 0500?
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Thu, 06 Nov 2003 02:28:48 +0900 (JST)
Cc: yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Organization: USAGI Project
Sender: netdev-bounce@xxxxxxxxxxx
David, please apply this. 
I don't see any reason to keep it 0500.
Thanks.
--- Begin Message ---
To: yoshfuji@xxxxxxxxxxxxxx
Subject: why is mode of /proc/sys/net/ipv6/icmp directory only 0500?
From: Tim Shepard <shep@xxxxxxxxxxxx>
Date: Wed, 05 Nov 2003 12:17:17 -0500
Sender: shep@xxxxxxxxxxxxxxxxxx

I did a google search to find why the mode of the
/proc/sys/net/ipv6/icmp directory is only 0500 and found that it
originates in a patch of yours:

        http://lwn.net/Articles/13656/

Why not have mode 0555, like this patch below?
If not 0555, then IMHO there needs to be a comment that justifies 0500.

                        -Tim Shepard


--- net/ipv6/sysctl_net_ipv6.c.DIST     2003-10-25 14:42:54.000000000 -0400
+++ net/ipv6/sysctl_net_ipv6.c  2003-11-05 12:10:34.000000000 -0500
@@ -22,25 +22,25 @@
 ctl_table ipv6_table[] = {
        {
                .ctl_name       = NET_IPV6_ROUTE,
                .procname       = "route",
                .maxlen         = 0,
                .mode           = 0555,
                .child          = ipv6_route_table
        },
        {
                .ctl_name       = NET_IPV6_ICMP,
                .procname       = "icmp",
                .maxlen         = 0,
-               .mode           = 0500,
+               .mode           = 0555,
                .child          = ipv6_icmp_table
        },
        {
                .ctl_name       = NET_IPV6_BINDV6ONLY,
                .procname       = "bindv6only",
                .data           = &sysctl_ipv6_bindv6only,
                .maxlen         = sizeof(int),
                .mode           = 0644,
                .proc_handler   = &proc_dointvec
        },
        {
                .ctl_name       = NET_IPV6_IP6FRAG_HIGH_THRESH,

--- End Message ---
<Prev in Thread] Current Thread [Next in Thread>