netdev
[Top] [All Lists]

Re: Bug somewhere in crypto or ipsec stuff

To: jmorris@xxxxxxxxxx
Subject: Re: Bug somewhere in crypto or ipsec stuff
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Thu, 30 Oct 2003 12:41:24 +0900 (JST)
Cc: paulus@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, davem@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <Xine.LNX.4.44.0310292221320.23405-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <20031030.121732.12858700.yoshfuji@xxxxxxxxxxxxxx> <Xine.LNX.4.44.0310292221320.23405-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <Xine.LNX.4.44.0310292221320.23405-100000@xxxxxxxxxxxxxxxxxxxxxxxx> 
(at Wed, 29 Oct 2003 22:22:50 -0500 (EST)), James Morris <jmorris@xxxxxxxxxx> 
says:

> On Thu, 30 Oct 2003, YOSHIFUJI Hideaki / [iso-2022-jp] 吉藤英明 wrote:
> 
> 
> > I would just disallow name == NULL,
> > well, what algorithm do you expect?
> 
> Good question.  It seems to me to be a bug in the calling code if it is 
> trying to look up nothing -- I'd rather not paper that over.

Do you mean that we need to fix the caller?

Well, people may want to get just any algorithm.
In such case,
 - crypto allows name == NULL, and return any algorithm
   (for example, an algorithm that we see first.)
 - caller may filter name == NULL case if it is ambiguous in their context.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>