netdev
[Top] [All Lists]

Re: [PATCH] ibmtr_cs/ibmtr on 2.6.0-test9 - get working again

To: Mike Phillips <phillim2@xxxxxxxxxxx>
Subject: Re: [PATCH] ibmtr_cs/ibmtr on 2.6.0-test9 - get working again
From: Andrew Morton <akpm@xxxxxxxx>
Date: Sat, 25 Oct 2003 15:56:49 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, torvalds@xxxxxxxx, jgarzik@xxxxxxxxx, shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20031025221435.GA18782@xxxxxxxxxxxxxxxx>
References: <20031025221435.GA18782@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Mike Phillips <phillim2@xxxxxxxxxxx> wrote:
>
> -    dev = alloc_trdev(sizeof(*info));
>  +    info = kmalloc(sizeof(*info), GFP_KERNEL); 
>  +    if (!info) return NULL;
>  +    memset(info,0,sizeof(*info));
>  +    dev = alloc_trdev(sizeof(struct tok_info));
>       if (!dev)
>           return NULL;

This return leaks the memory at `info'.

<Prev in Thread] Current Thread [Next in Thread>