| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] tun driver use private linked list. |
| From: | Max Krasnyansky <maxk@xxxxxxxxxxxx> |
| Date: | Tue, 21 Oct 2003 08:55:54 -0700 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20031009125929.6f2d99f9.shemminger@xxxxxxxx> |
| References: | <5.1.0.14.2.20031009110604.05a541b0@xxxxxxxxxxxxxxxxxxxxx> <5.1.0.14.2.20030812092213.08dc6ea0@xxxxxxxxxxxxxxxxxxxxx> <20030808113404.0e9e1e6d.shemminger@xxxxxxxx> <200308051630.28552.bellucda@xxxxxxxxxx> <20030805090647.691daa7e.shemminger@xxxxxxxx> <200308051910.55823.bellucda@xxxxxxxxxx> <20030807154524.4794ad45.shemminger@xxxxxxxx> <20030807155901.49f1a424.davem@xxxxxxxxxx> <20030808113404.0e9e1e6d.shemminger@xxxxxxxx> <5.1.0.14.2.20030812092213.08dc6ea0@xxxxxxxxxxxxxxxxxxxxx> <5.1.0.14.2.20031009110604.05a541b0@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
At 12:59 PM 10/9/2003, Stephen Hemminger wrote: >On Thu, 09 Oct 2003 11:45:31 -0700 >Max Krasnyansky <maxk@xxxxxxxxxxxx> wrote: > >> Actually in case of persistent devices we can not let the module go away. >> Because it has >> important info like user id of the owner and stuff which is not stored >> anywhere else. >> It also provides device name reservation, UML folks use it for example to >> reserve certain >> devices to a certain users. If module goes away admin will have to recreate >> those devices >> again. TUN/TAP devices are created in ioctl and since vfs layer already >> holds a reference, >> like you said, it's safe for us to just do __module_get()/module_put(). > >I think letting the admin do what he requests is the right thing. The >philosophy of >module unload has changed: with 2.4 it was "don't let admin unload the network >element if anything is using it"; now it is "let the admin unload any module >and cleanup as necessary". Yeah, I don't necessarily agree with that :). But I guess you can argue that only admin can unload the module. And he probably knows what he's doing. Max |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFT] merged 8139too NAPI, OGAWA Hirofumi |
|---|---|
| Next by Date: | Re: [PATCH][2.6] fix compilation w/o CONFIG_XFRM, Marcelo Abreu |
| Previous by Thread: | Re: [PATCH] tun driver use private linked list., Stephen Hemminger |
| Next by Thread: | 2.6.0-test7-netx1, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |