| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] (5/6) ibmtr -- probe2 |
| From: | Mike_Phillips@xxxxxxxxxxx |
| Date: | Fri, 17 Oct 2003 10:34:54 -0300 |
| Cc: | jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, netdev-bounce@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
>>
>> > typedef struct ibmtr_dev_t {
>> > + struct tok_info ti; /* must be first! */
>>
>> Why must this be first ?? Sounds like an alignment issue, we shouldn't
>> assume some is aligned correctly just because it's the first entry.
>Because ibmtr_cs calls ibmtr_probe1 function which does:
> struct tok_info *ti = dev->priv;
>and dereferences it in a couple of places.
Huh ?? All the patch did was move the definition of ti to the start of the
struct ibmtr_dev_t
Mike
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: oops in skbuff.c, Sebastian Piecha |
|---|---|
| Next by Date: | Re: [PATCH] (5/6) ibmtr -- probe2, Mike_Phillips |
| Previous by Thread: | Re: [PATCH] (5/6) ibmtr -- probe2, Stephen Hemminger |
| Next by Thread: | Re: [PATCH] (5/6) ibmtr -- probe2, Mike_Phillips |
| Indexes: | [Date] [Thread] [Top] [All Lists] |