Re: [PATCH?] Fix sniffing of ARP replies

[Petr Vandrovec <vandrove@xxxxxxxxxx>]

On Thu, Oct 16, 2003 at 03:45:37PM -0700, David S. Miller wrote:
> On Thu, 16 Oct 2003 15:41:00 -0700
> Joe Perches <joe@xxxxxxxxxxx> wrote:
> 
> > On Thu, 2003-10-16 at 15:21, David S. Miller wrote:
> > vmware wasn't just trying to influence, it used the implementation.
> 
> It just so happened to be usable in this way.
> 

I do not understand. At least on hardware and configurations I tested
code still works if I set af_packet_priv member to some non-NULL value.
It looked to me like that it is not intentional that ARP replies are not
delivered to the sniffer - from your reply it looks to me like that
only allowed user  of whole packet_type, not only af_packet_priv member,
is AF_PACKET, and that for correct functionality af_packet_priv member
must be non-NULL. Otherwise semantic of this call is ungrokable by
me (it is ungrokable anyway as vital information where checksum should
be placed is lost, but you already said that it is intentional that tcpdump
sees it wrong).

For now I understand that I should set af_packet_priv to non-NULL value.
                                                Best regards,
                                                        Petr Vandrovec
                                                        vandrove@xxxxxxxxxx