netdev
[Top] [All Lists]

Re: [PATCH] Fix 64bit warnings in rtl8139too

To: Andi Kleen <ak@xxxxxx>
Subject: Re: [PATCH] Fix 64bit warnings in rtl8139too
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Tue, 14 Oct 2003 14:13:04 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031007175638.GA1754@averell>
References: <20031007175638.GA1754@averell>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703
Andi Kleen wrote:
Fix a harmless 64bit pointer/integer mismatch warning in 8139too.

diff -u linux-2.5-cleanup/drivers/net/8139too.c-o 
linux-2.5-cleanup/drivers/net/8139too.c
--- linux-2.5-cleanup/drivers/net/8139too.c-o   2003-09-08 00:02:03.000000000 
+0200
+++ linux-2.5-cleanup/drivers/net/8139too.c     2003-12-02 17:13:24.634752560 
+0100
@@ -746,7 +746,8 @@
        u8 tmp8;
        int rc;
        unsigned int i;
-       u32 pio_start, pio_end, pio_flags, pio_len;
+       unsigned long pio_start;
+       u32 pio_end, pio_flags, pio_len;
        unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
        u32 version;


Why not just make this look like mmio_*?

        Jeff




<Prev in Thread] Current Thread [Next in Thread>